[Lldb-commits] [PATCH] D137509: [NFC][intelpt] Improve IntelPT trace bundle documentation

[walter erquinigo via Phabricator via lldb-commits]

wallace accepted this revision.
wallace added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp:244
           // Optional clang/llvm target triple.
+          // This must be provided if the trace will be created not using the CLI or on a machine other than where the target was traced.
       "threads": [
----------------
jj10306 wrote:
> wallace wrote:
> > split this into 80-char lines, please :)
> wonder why `git clang-format` didn't suggest this?
I think it's because this is a special kind of string that should be taken literal


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137509/new/

https://reviews.llvm.org/D137509