[Lldb-commits] [PATCH] D126260: [lldb/crashlog] Add support for Application Specific Backtraces & Information

[Med Ismail Bennani via Phabricator via lldb-commits]

mib marked 7 inline comments as done.
mib added inline comments.


================
Comment at: lldb/examples/python/crashlog.py:601-605
+        for idx, backtrace in enumerate(json_app_specific_bts):
+            thread = self.crashlog.Thread(idx, True)
+            thread.queue = "Application Specific Backtrace"
+            if parse_asi_backtrace(self, thread, backtrace):
+                self.crashlog.threads.append(thread)
----------------
JDevlieghere wrote:
> I don't think it's correct to treat the ASI as just another thread. IIUC it's the same as the crashing thread, just at another point in time (when the exception was thrown). To me that sounds like it should be its own thing.
This allows to show the Application Specific Backtrace with other threads when using the non-interactive crashlog command.

For interactive crashlogs, the Application Specific Backtrace is attached to the crashed thread as its extended backtrace and would only be show when doing `thread backtrace --extended true`


================
Comment at: lldb/include/lldb/Interpreter/ScriptedProcessInterface.h:105
+
+  virtual StructuredData::ArraySP GetExtendedInfo() { return nullptr; }
 };
----------------
JDevlieghere wrote:
> 
ditto


================
Comment at: lldb/include/lldb/Target/Process.h:2431
+  ///     information related to the process.
+  virtual StructuredData::DictionarySP GetMetadata() { return nullptr; }
+
----------------
JDevlieghere wrote:
> 
I'll make a follow-up patch to update this. (D137359)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126260/new/

https://reviews.llvm.org/D126260