[Lldb-commits] [PATCH] D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions

[Philip Pfaffe via Phabricator via lldb-commits]

pfaffe added inline comments.


================
Comment at: lldb/unittests/Expression/DWARFExpressionTest.cpp:719
+  Type:            ET_EXEC
+  Machine:         EM_386
+Sections:
----------------
DavidSpickett wrote:
> I know it's just a test but is there an `EM_WASM` you could use?
> 
> Maybe lldb doesn't understand that name yet so it makes no difference anyway.
There's no EM_WASM, in fact wasm has it's own non-ELF container. I picked x86 ELF  because ELFYAML has the DWARF section which is convenient, WASMYAML sadly does not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137247/new/

https://reviews.llvm.org/D137247