[Lldb-commits] [PATCH] D137284: Override CalculateFrameVariableError in SymbolFileOnDemand

[jeffrey tan via Phabricator via lldb-commits]

yinghuitan requested changes to this revision.
yinghuitan added inline comments.
This revision now requires changes to proceed.


================
Comment at: lldb/include/lldb/Symbol/SymbolFileOnDemand.h:121
+  lldb_private::Status
+  CalculateFrameVariableError(lldb_private::StackFrame &frame) override;
+
----------------
Please add a unit test which should fail in symbol on-demand mode but succeeds after your patch. Checkout Greg's original test checking frame variable error as example.


================
Comment at: lldb/source/Symbol/SymbolFileOnDemand.cpp:277-279
+Status SymbolFileOnDemand::CalculateFrameVariableError(StackFrame &frame) {
+  return m_sym_file_impl->CalculateFrameVariableError(frame);
+}
----------------
You should only forward to underlying `m_sym_file_impl->CalculateFrameVariableError()` when `m_debug_info_enabled` is true otherwise it will trigger parsing of debug info. Follow the pattern in other methods of this file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137284/new/

https://reviews.llvm.org/D137284