[Lldb-commits] [PATCH] D137098: [lldb] Support simplified template names in the manual index

Wed Nov 2 14:30:04 PDT 2022

aeubanks added a comment.

In D137098#3902140 <https://reviews.llvm.org/D137098#3902140>, @labath wrote:

> Why is it that the other indexes don't need an equivalent fix? Could it be that you just haven't tried those code paths?
>
> If they do need it, then it'd be good if we could make the fix in a single place. Possibly by putting the retry logic at a higher level?

Other indexes as in the other manual index indexes? Or as in other higher level indexes?

================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp:450
   }
   if (name_type_mask & eFunctionNameTypeBase) {
     if (!m_set.function_basenames.Find(
----------------
labath wrote:
> Are you sure this doesn't need to be repeated for `eFunctionNameTypeBase`? that's where non-member functions end up...
you're right, but I've moved this up into SymbolFileDWARF

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137098/new/

https://reviews.llvm.org/D137098