[Lldb-commits] [PATCH] D137191: [lldb] Add information on type systems to statistics dump command
Thorsten via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Nov 1 14:18:18 PDT 2022
tschuett added inline comments.
================
Comment at: lldb/source/Target/Statistics.cpp:266
+ auto stats = ts->ReportStatistics();
+ if (stats.hasValue()) {
+ module_stat_obj->try_emplace("TypeSystemInfo", stats.getValue());
----------------
clayborg wrote:
> Remove {} for single line if statement per llvm coding guidelines
I am bit confused. If `auto stats` is an `optional`. Please remove `.hasValue()` and replace `stats.getValue` by `*stats`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137191/new/
https://reviews.llvm.org/D137191
More information about the lldb-commits
mailing list