[Lldb-commits] [PATCH] D137137: [lldb/Interpreter] Open saved transcript in GUI Editor

Mon Oct 31 17:08:41 PDT 2022

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

Should this be controllable with a setting? I'm not sure I (always) want my editor to pop up when I save a transcript.

================
Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:3232
+      if (!Host::OpenFileInExternalEditor(file_spec, 1))
+        result.AppendMessage("Unable to open file in external editor\n");
+  }
----------------
If we want to report the error we should should use `AppendErrorMessage` and return false, but personally I don't think this warrants failing the command for and I would just fail silently.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137137/new/

https://reviews.llvm.org/D137137