[Lldb-commits] [PATCH] D137098: [lldb] Support simplified template names in the manual index

David Blaikie via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 31 12:58:17 PDT 2022


dblaikie added a comment.

In D137098#3897289 <https://reviews.llvm.org/D137098#3897289>, @aeubanks wrote:

> updated description with why this doesn't produce false positives with breakpoints
>
> this doesn't support regex function name lookup, not sure if we care enough about the interaction between regexes/function names under simple template names. if we do, we could instead add template parameters to the names we put in the manual index. I did take a quick look at doing that but it'd require more work

Presumably that'd then lead to divergence between manual and automatic index - which would be bad. So if this behavior is the same between automatic and manual index with simplified template names, that's probably good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137098/new/

https://reviews.llvm.org/D137098



More information about the lldb-commits mailing list