[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

[Jorge Gorbe Moya via Phabricator via lldb-commits]

jgorbe added a comment.

> You can't provide the --regex option and this matcher at the same time

Thanks for spotting this. I'll get to it.

> it is also an error to have both this matcher function and any arguments in the argument list

Not with the code as it is. I've made the new flag have similar semantics to `--regex`. If I'm not mistaken, with `--regex`, all the arguments in the argument list are treated as regular expressions instead of type names, and with `--recognizer-function` all the arguments in the argument list will be treated as recognizer functions instead.

Would you prefer having the `--recognizer-function` flag take an argument instead and error out if the argument list is not empty? On one hand I can see the argument for that being somewhat more intuitive. On the other hand, making the new flag be "special" (in the sense that it doesn't behave like `--regex`) makes the command set a little less consistent which IMO is less intuitive. I'm happy to go either way if you have a strong opinion about the way it should work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137000/new/

https://reviews.llvm.org/D137000