[Lldb-commits] [PATCH] D136761: [lldb][CPlusPlus] Implement CPlusPlusLanguage::GetFunctionDisplayName

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 31 05:18:34 PDT 2022


labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

This isn't your fault, but this `GetFunctionDisplayName` doesn't seems particularly well suited, as it forces you to reimplement a lot of the printing functionality for each language plugin.  I'd expect the customization point to be something like your helper `PrettyPrintFunctionNameWithArgs` function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136761/new/

https://reviews.llvm.org/D136761



More information about the lldb-commits mailing list