[Lldb-commits] [PATCH] D136934: [lldb][FormatEntity][NFC] Move function argument parsing code into separate functions

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added inline comments.


================
Comment at: lldb/source/Core/FormatEntity.cpp:1057
+  // the arguments list
+  if (generic && open_paren && generic < open_paren) {
+    int generic_depth = 1;
----------------
aprantl wrote:
> Would be nice to rewrite this on top of StringRef at some point.
After we stop using this for c++, I think we should replace this code with something really simple (e.g., drop everything after the first `(`), and tell everyone to write their language plugins if they need more.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136934/new/

https://reviews.llvm.org/D136934