[Lldb-commits] [PATCH] D136938: [LLDB] Fix code breakpoints on tagged addresses

[David Spickett via Phabricator via lldb-commits]

DavidSpickett created this revision.
Herald added subscribers: atanasyan, arichardson, sdardis.
Herald added a project: All.
DavidSpickett requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

This allows you to break on the value of a function pointer
with non-address bits in it. For example your ABI might mandate
function pointer signing.

Previously it would either try to write to an address that was
incorrect, or try to set a hardware register incorrectly.

I have placed the ABI check before GetBreakableLoadAddress
on the logic that that function probably works best with a
fixed address.

This is somewhat academic because the only user of
GetBreakableLoadAddress is MIPS where we don't support any
form of address tagging.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D136938

Files:
  lldb/source/Target/Target.cpp
  lldb/test/API/linux/aarch64/tagged_code_break/Makefile
  lldb/test/API/linux/aarch64/tagged_code_break/TestAArch64LinuxTaggedCodeBreak.py
  lldb/test/API/linux/aarch64/tagged_code_break/main.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136938.471477.patch
Type: text/x-patch
Size: 3978 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20221028/c69cfa26/attachment.bin>