[Lldb-commits] [PATCH] D136795: [LLDB] Add a `(not loaded) ` prefix to placeholder object filename to indicate they are not loaded.

Fri Oct 28 01:14:13 PDT 2022

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

I'm not entirely sold on the string "(not loaded)". Maybe would be ok for the user, but to me it sounds extremely weird, because the main reason we are creating this module is so that we can pretend there is something "loaded" at the given address. If you don't like "placeholder", what would you say to "(artificial)" ?

================
Comment at: lldb/test/Shell/Minidump/modules-not-loaded.yaml:7
+# CHECK:      (lldb) target modules list
+# CHEKC-NEXT: [  0] 04000000-1400-0000-0300-0000474E5500 0x00001000 (not loaded) /invalid/path/on/current/system/libbreakpad.so
+
----------------

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136795/new/

https://reviews.llvm.org/D136795