[Lldb-commits] [PATCH] D136362: [LLDB][RISCV] Add RV64C instruction support for EmulateInstructionRISCV

[Tiezhu Yang via Phabricator via lldb-commits]

seehearfeel added a subscriber: SixWeining.
seehearfeel added a comment.

In D136362#3890970 <https://reviews.llvm.org/D136362#3890970>, @DavidSpickett wrote:

> Can you give us:
>
> - the full cmake command you used to configure the project



  git clone https://github.com/llvm/llvm-project.git
  mkdir -p llvm-project/llvm/build
  cd llvm-project/llvm/build
  cmake .. -G "Ninja" -DLLVM_TARGETS_TO_BUILD="BPF" \
           -DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD="LoongArch" \
           -DLLVM_ENABLE_PROJECTS="clang;lldb" \
           -DCMAKE_BUILD_TYPE=Release \
           -DLLVM_BUILD_RUNTIME=OFF
  ninja
  ninja check-lldb -j1



> - the gcc/g++ version used

gcc (GCC) 13.0.0 20220919
g++ (GCC) 13.0.0 20220919

> - the distro used

clfs loongarch

> - the architecture (unlikely to matter but I'm assuming Loongson?)

LoongArch

> - the version of clang++ that did work

clang version 14.0.6

> Could be tripping over a bug in g++. If that version is >= the minimum llvm requires we should look for a workaround.
>
> One thing you could try is removing parts of `TestRISCVEmulator.cpp` and seeing what breaks the build. Though this is best done by @Emmmer, if it can be reproduced elsewhere.

This is introduced in the following commit:

  $ git log -p lldb/unittests/Instruction/RISCV/TestRISCVEmulator.cpp
  commit 05ae747a5353811f93f5814f24d2335e6229d78a
  Author: Emmmer <yjhdandan at 163.com>
  Date:   Thu Oct 20 23:05:37 2022 +0800
  
      [LLDB][RISCV] Add RV64C instruction support for EmulateInstructionRISCV

c++ OOM is related with this vector, if it is empty, building is OK, if it has one element at least, build failed.

  std::vector<TestDecode> tests = {
   };

@SixWeining can also reproduce it on his local machine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136362/new/

https://reviews.llvm.org/D136362