[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

[Michael Buch via Phabricator via lldb-commits]

Michael137 added inline comments.


================
Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:3831
+
+  clang::PrintingPolicy printing_policy(GetTypePrintingPolicy());
+  printing_policy.SuppressScope = true;
----------------
Could we just re-use `GetTypeName` and add an optional printing policy argument to it?


================
Comment at: lldb/test/API/lang/cpp/unique-types2/main.cpp:20
+  FooPack<int, int> t6;
+  FooPack<int, int, int> t7;
+  // Set breakpoint here
----------------
aeubanks wrote:
> labath wrote:
> > Would it be interesting to test nested types as well (`Foo<T>::Bar<U>`) ?
> yes, and that caught a bug, thanks for the suggestion
> 
> I've added a `Type::GetBaseName()`, could you take a look at that?
Out of curiosity, what was the issue with using the qualified name?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134378/new/

https://reviews.llvm.org/D134378