[Lldb-commits] [PATCH] D136209: [LLDB][NativePDB] Fix parameter size for member functions LF_MFUNCTION

Thu Oct 27 07:13:16 PDT 2022

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

In D136209#3880121 <https://reviews.llvm.org/D136209#3880121>, @zequanwu wrote:

> In D136209#3878821 <https://reviews.llvm.org/D136209#3878821>, @labath wrote:
>
>> So if I understand correctly, when we deserialize incorrectly, this causes us to misclassify some function parameters (arguments) as local variables. Is that correct? If yes, then that is something that can be checked. Even if the misclassified variables behave perfectly, their kind is still visible, e.g. in the output of "frame variable --scope".
>
> It's the opposite. Some non parameters local variables are misclassified as parameters, since deserialized parameter count is incorrect/larger. Those misclassified local variables will have the parameter bit set. See the inline comment for detail.

Ugh, yeah, carry on as you were.

> Or maybe we should just rely on individual variable's debug info to determine if a local var is parameter or not, not the parameter count found in function debug info.

If it's sufficient, then yeah, definitely.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136209/new/

https://reviews.llvm.org/D136209