[Lldb-commits] [PATCH] D136761: [lldb][FormatEntity] Fix closing parenthesis for function.name-with-args frame format

[Michael Buch via Phabricator via lldb-commits]

Michael137 added a comment.

> Keep the argument printing part, and replace the basename parsing with a call to the language parser ?

The two main caveats here are:

1. the name parser drops the return type when parsing a basename
2. the code-path is also used for cases where a language plugin isn't available (not sure how often/whether that happens in practice). So I don't think we can "replace"

I think we want to:

1. Add something like `CPlusPlusNameParser::MethodName::GetReturnType`
2. Implement `CPlusPlusLanguage::GetFunctionDisplayName` where we could re-use the argument parsing code from `FormatEntity` but get the basename from the language plugin

Shouldn't be too bad


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136761/new/

https://reviews.llvm.org/D136761