[Lldb-commits] [PATCH] D136795: [LLDB] Mark placeholder modules in `target module list` output.

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Oct 27 00:35:13 PDT 2022


labath added a comment.

It's a good idea, but this is a pretty bad layering violation. The "placeholder" object files aren't even first class plugins (though I think they should be -- as the concept is useful in other situations as well), but an internal detail of the minidump process plugin.

Ideally, we would do this from inside the minidump code, perhaps by modifying the name (file spec) of the fake object file?

A test would be nice as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136795/new/

https://reviews.llvm.org/D136795



More information about the lldb-commits mailing list