[Lldb-commits] [PATCH] D136798: [lldb] Explicitly open file to write with utf-8 encoding in crashlog.py

Jordan Rupprecht via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 26 16:26:29 PDT 2022


rupprecht accepted this revision.
rupprecht added a comment.
This revision is now accepted and ready to land.

Two other places you might need to update as well



================
Comment at: lldb/examples/python/crashlog.py:452
 
         with open(path, 'r') as f:
             buffer = f.read()
----------------
Do you need to specify encoding here too?


================
Comment at: lldb/examples/python/crashlog.py:647
     def parse(self):
         with open(self.path,'r') as f:
             lines = f.read().splitlines()
----------------
(and here)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136798/new/

https://reviews.llvm.org/D136798



More information about the lldb-commits mailing list