[Lldb-commits] [PATCH] D136719: change debugserver to return an empty platform name for unknown platforms, instead of crashing

[Thorsten via Phabricator via lldb-commits]

tschuett added a comment.

In D136719#3885974 <https://reviews.llvm.org/D136719#3885974>, @jasonmolenda wrote:

> In D136719#3884836 <https://reviews.llvm.org/D136719#3884836>, @tschuett wrote:
>
>> How about an optional instead, if GetPlatformString is fallible.
>
> Ah, interesting idea.  debugserver doesn't use any llvm, but I believe we're building with C++17 these days so I could do it with std::optional.

Yep.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136719/new/

https://reviews.llvm.org/D136719