[Lldb-commits] [PATCH] D136465: Make remote-android local ports configurable

Tue Oct 25 16:46:55 PDT 2022

clayborg added a comment.

Looks ok to me. I don't do Android stuff on a daily basis. As long as the old way of connecting still works I think this is ok.

It would be great to get more stuff in the Android remove platform connection working at some point. Users still have to manually install things and a lot of the work gets done by the Android Studio IDE kind of like Xcode does. I would love to us add some features in the future:

- allow a lldb_private::Target to have an application bundle FileSpec, which could be pointed to a .apk file for Android and a .ipa file for iOS
- Implement PlatformAndroid::LaunchProcess
  - implement "Status PlatformAndroid::Install(const FileSpec &src, const FileSpec &dst)" and handle APK files from target by doing "adb install" if needed
  - Have PlatformAndroid::LaunchProcess do everything that is needed to debug the app
    - start lldb-server for the new process via the connect to the "lldb-server platform" process
    - forward any ports needed

It would be great at some point to be able to do something like:

  (lldb) platform select remote-android
  (lldb) platform connect ...
  (lldb) target create --app-bundle /path/to/foo.apk
  (lldb) run

And have PlatformAndroid take care of everything for us.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136465/new/

https://reviews.llvm.org/D136465