[Lldb-commits] [PATCH] D134991: [lldb] Add diagnostics

[Greg Clayton via Phabricator via lldb-commits]

clayborg requested changes to this revision.
clayborg added inline comments.
This revision now requires changes to proceed.


================
Comment at: lldb/lldb/include/lldb/Utility/Diagnostics.h:1
+//===-- Diagnostics.h -------------------------------------------*- C++ -*-===//
+//
----------------
There are two of these files:
```
lldb/include/lldb/Utility/Diagnostics.h
lldb/lldb/include/lldb/Utility/Diagnostics.h
```
Remove this one I assume?


================
Comment at: lldb/lldb/source/Utility/Diagnostics.cpp:1
+//===-- Diagnostics.cpp ---------------------------------------------------===//
+//
----------------
Is "lldb/lldb/source/Utility/Diagnostics.cpp" the right directory? Seems wrong


================
Comment at: lldb/source/Utility/Diagnostics.cpp:1
+//===-- Diagnostics.cpp ---------------------------------------------------===//
+//
----------------
Ah, this is the right lldb/source/Utility/Diagnostics.cpp file. Remove the previous lldb/lldb/source/Utility/Diagnostics.cpp incorrect pathed file.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134991/new/

https://reviews.llvm.org/D134991