[Lldb-commits] [PATCH] D136462: [LLDB] Add color to output text when searching for symbols

[Varun Kumar E via Phabricator via lldb-commits]

varunkumare99 added a comment.

In D136462#3878895 <https://reviews.llvm.org/D136462#3878895>, @DavidSpickett wrote:

> I agree that this change names - print - restore names is going to cause problems. Pavel is right that this should happen in some dump function somewhere.
>
> But, assuming what you've got works to an extent, you should add some testing first. That will allow you to refactor with less risk. You'll be able to reuse a lot of the tests later, so it's not wasted effort and it'll flush out some corner cases you haven't thought of.

Thanks. I start out with adding some testing first. Then look into adding colouration in dump functions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136462/new/

https://reviews.llvm.org/D136462