[Lldb-commits] [PATCH] D136648: [lldb] Emit diagnostic events in the diagnostic dump

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

(Unsurprisingly, I guess), this looks much better to me. And I'm totally open to automatically logging these diagnostics somewhere as well (to a dedicated log channel/category, or by passing the log as an argument, or something else).



================
Comment at: lldb/source/Utility/Diagnostics.cpp:92
+
+llvm::Error Diagnostics::DumpAlwaysOnLog(const FileSpec &dir) const {
+  FileSpec log_file = dir.CopyByAppendingPathComponent("diagnostics.log");
----------------
Maybe call this DumpDiangosticsLog ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136648/new/

https://reviews.llvm.org/D136648