[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

Will Hawkins via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 24 15:09:26 PDT 2022


hawkinsw reopened this revision.
hawkinsw added a comment.
This revision is now accepted and ready to land.

I updated this revision with the following change and I *think* that things are happy again:

  diff --git a/lldb/source/Core/ValueObject.cpp b/lldb/source/Core/ValueObject.cpp
  index 226a2c3f690f..1f939c6fa2cd 100644
  --- a/lldb/source/Core/ValueObject.cpp
  +++ b/lldb/source/Core/ValueObject.cpp
  @@ -2004,6 +2004,11 @@ void ValueObject::GetExpressionPath(Stream &s,
         s.PutChar(')');
     }
   
  +  if (m_flags.m_is_array_item_for_pointer &&
  +      epformat == eGetExpressionPathFormatHonorPointers) {
  +    s.PutCString(m_name.GetStringRef());
  +  }
  +
     if (print_obj_access)
       s.PutChar('.');
     if (print_ptr_access)

Let me know if that is helpful.

Sincerely,
Will


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132734/new/

https://reviews.llvm.org/D132734



More information about the lldb-commits mailing list