[Lldb-commits] [PATCH] D136600: [lldb-tests] Force use of system stdlib for Objective-C test

[Felipe de Azevedo Piovezan via Phabricator via lldb-commits]

fdeazeve created this revision.
fdeazeve added a reviewer: aprantl.
Herald added a project: All.
fdeazeve requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

The test TestObjCDirectMethods loads the Objective C runtime, which
doesn't work well with custom a libcxx, resulting in two copies of the
standard library to be loaded at runtime. Like what was done for
`TestObjCExceptions`, this commit forces the usage of the system's
library instead. The minimum required Clang version is set to the oldest
Clang that can compile the libraries available in the lldb-matrix bots.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D136600

Files:
  lldb/test/API/lang/objc/objc_direct-methods/Makefile
  lldb/test/API/lang/objc/objc_direct-methods/TestObjCDirectMethods.py


Index: lldb/test/API/lang/objc/objc_direct-methods/TestObjCDirectMethods.py
===================================================================
--- lldb/test/API/lang/objc/objc_direct-methods/TestObjCDirectMethods.py
+++ lldb/test/API/lang/objc/objc_direct-methods/TestObjCDirectMethods.py
@@ -1,4 +1,6 @@
 from lldbsuite.test import lldbinline
+from lldbsuite.test import decorators
 
+decor = [decorators.skipIf(compiler="clang", compiler_version=['<', '13.0'])]
 lldbinline.MakeInlineTest(
-    __file__, globals(), [])
+    __file__, globals(), decor)
Index: lldb/test/API/lang/objc/objc_direct-methods/Makefile
===================================================================
--- lldb/test/API/lang/objc/objc_direct-methods/Makefile
+++ lldb/test/API/lang/objc/objc_direct-methods/Makefile
@@ -1,4 +1,5 @@
 OBJC_SOURCES := main.m
 LD_EXTRAS := -lobjc -framework Foundation
+USE_SYSTEM_STDLIB := 1
 
 include Makefile.rules


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136600.470144.patch
Type: text/x-patch
Size: 931 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20221024/b729c122/attachment.bin>