[Lldb-commits] [PATCH] D136551: [lldb] Include gtest in standalone build only if LLDB_INCLUDE_TESTS

Mon Oct 24 05:39:33 PDT 2022

labath added inline comments.

================
Comment at: lldb/CMakeLists.txt:20

+option(LLDB_INCLUDE_TESTS "Generate build targets for the LLDB unit tests." ${LLVM_INCLUDE_TESTS})
+
----------------
mgorny wrote:
> labath wrote:
> > mgorny wrote:
> > > To be honest, I don't exactly like moving this `option`. The alternative I can think of is moving gtest and LLVMTestingSupport logic from `LLDBStandalone` into unittests.
> > So, how does this work in non-standalone builds? Is gtest built unconditionally, or is it guarded by something else (LLVM_INCLUDE_TESTS perhaps?)
> It's guarded by `LLVM_INCLUDE_UTILS` + `LLVM_INCLUDE_TESTS`.
Ok, I think that's fine. I'm not particularly upset by that. Doing this work in the unittest directory would probably be fine too...

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136551/new/

https://reviews.llvm.org/D136551