[Lldb-commits] [PATCH] D136462: [LLDB] Add color to output text when searching for symbols

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

This is definitely not a good way to implement this functionality. There's no telling who else might be accessing the symbols while their names are being changed.

The colouration should be implemented inside the dumping function, without modifying the state of the debugger. I realize that's not currently easy to do, but that's not a reason to do this. It's possible the dumping machinery needs to be refactored to support this kind of customized colouration.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136462/new/

https://reviews.llvm.org/D136462