[Lldb-commits] [PATCH] D136465: Make remote-android local ports configurable

Mon Oct 24 01:58:52 PDT 2022

mark2185 added a comment.

In D136465#3878640 <https://reviews.llvm.org/D136465#3878640>, @DavidSpickett wrote:

> Ok, so this change means that the randomisation still happens, unless you override it with these environment variables? This seems like a good way to do it.

Exactly, this is completely opt-in. This approach with `environment` variables was easy enough, and it was used in other things related to `adb` so it seemed fitting. Maybe it would be better to set it through `platform settings`, but I'd rather have someone chip in on that.

Also the burden of making sure the ports are //actually// free is on the user, but I'm guessing the user is aware of this since they are using custom ports.

> Where do these env vars need to be set? On the local machine, on the lldb-server machine, on the device?

These are **client-side** variables, since that is where the user is launching `lldb` from. `adb` will only get a request `forward tcp:<my-port> tcp:<platform-port>` instead of `forward tcp:<random> tcp:<platform-port>`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136465/new/

https://reviews.llvm.org/D136465