[Lldb-commits] [PATCH] D136209: [LLDB][NativePDB] Fix parameter size for member functions LF_MFUNCTION

[Reid Kleckner via Phabricator via lldb-commits]

rnk added a comment.

Right, so `cantFail` must be an assertions-only check. That's not great. These deserialization APIs have really, really bad ergonomics and could use a lot of improvement if you want to look into that.

It would be really nice if, for example, this worked more like dyn_cast. Consider this kind of code:

  CVType signature;
  NewTypeMatcher d(signature);
  if (auto *sig = d.getAs<ProcedureRecord>()) {
     ... handle ProcedureRecord
  } else if (auto *sig = d.getAs<MemberFunctionRecord>()) {
    ... handle MemberFunctionRecord
  }


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136209/new/

https://reviews.llvm.org/D136209