[Lldb-commits] [PATCH] D136178: [lldb-tests] Add compiler version check in TestFunctionStarts

[Felipe de Azevedo Piovezan via Phabricator via lldb-commits]

fdeazeve created this revision.
fdeazeve added reviewers: aprantl, Michael137.
Herald added a project: All.
fdeazeve requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

This test requires compiling its input program without debug
information. To do so, it uses certain Makefile variables that are never
populated with custom libcxx paths (if present). Doing so would not
necessarily be correct, since we cannot guaranteed that said standard
library has debug symbols or not.

As such, we keep using the system libraries but to disable the tests in
clang versions that are too old to work with more modern system
libraries, as in the case of the lldb-matrix bot.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D136178

Files:
  lldb/test/API/macosx/function-starts/TestFunctionStarts.py


Index: lldb/test/API/macosx/function-starts/TestFunctionStarts.py
===================================================================
--- lldb/test/API/macosx/function-starts/TestFunctionStarts.py
+++ lldb/test/API/macosx/function-starts/TestFunctionStarts.py
@@ -17,6 +17,7 @@
 
     @skipIfRemote
     @skipUnlessDarwin
+    @skipIf(compiler="clang", compiler_version=['<', '13.0'])
     def test_function_starts_binary(self):
         """Test that we make synthetic symbols when we have the binary."""
         self.build(dictionary={'CODESIGN': ''}) # Binary is getting stripped later.
@@ -24,6 +25,7 @@
 
     @skipIfRemote
     @skipUnlessDarwin
+    @skipIf(compiler="clang", compiler_version=['<', '13.0'])
     def test_function_starts_no_binary(self):
         """Test that we make synthetic symbols when we don't have the binary"""
         self.build(dictionary={'CODESIGN': ''}) # Binary is getting stripped later.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136178.468549.patch
Type: text/x-patch
Size: 928 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20221018/4ea0f5e3/attachment.bin>