[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names
Arthur Eubanks via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Oct 6 16:36:23 PDT 2022
aeubanks added inline comments.
================
Comment at: lldb/test/API/lang/cpp/unique-types2/TestUniqueTypes.py:1
+"""
+Test that we return only the requested template instantiation.
----------------
Michael137 wrote:
> I think it would be good to test this with `-gsimple-template-names`/`-gno-simple-template-names`
>
> You can pass in a dictionary into `self.build()` and override Makefile flags
>
> E..g, in `lldb/test/API/lang/c/forward/TestForwardDeclaration.py` we do this for `-gdwarf-5`.
>
> So you could have two `test_XXX` methods like:
> ```
> def do_test(self, debug_flags):
> self.build(dictionary=debug_flags)
> ... actual test ...
>
> def test_simple_template_name(self):
> do_test(self, dict(CFLAGS_EXTRAS="-gsimple-template-names")
>
> def test_no_simple_template_name(self):
> do_test(self, dict(CFLAGS_EXTRAS="-gno-simple-template-names")
> ```
thanks, that's very useful to know! done
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134378/new/
https://reviews.llvm.org/D134378
More information about the lldb-commits
mailing list