[Lldb-commits] [lldb] 01470b6 - [lldb] Fix hard-coded argument to set_target_properties

[Jonas Devlieghere via lldb-commits]

Author: Jonas Devlieghere
Date: 2022-10-06T11:43:52-07:00
New Revision: 01470b68f392af8bbf95b2ab48253b1662e2cdc7

URL: https://github.com/llvm/llvm-project/commit/01470b68f392af8bbf95b2ab48253b1662e2cdc7
DIFF: https://github.com/llvm/llvm-project/commit/01470b68f392af8bbf95b2ab48253b1662e2cdc7.diff

LOG: [lldb] Fix hard-coded argument to set_target_properties

The call to `set_target_properties` should use the target passed to
`add_lldb_library` instead of a hard-coded value. Upstream `liblldb` is
the only target for which this matters, but downstream we have
LLDBRPC.framework which needs this as well.

Added: 
    

Modified: 
    lldb/cmake/modules/AddLLDB.cmake

Removed: 
    


################################################################################
diff  --git a/lldb/cmake/modules/AddLLDB.cmake b/lldb/cmake/modules/AddLLDB.cmake
index 3291a7c808e16..ea52b47d6d727 100644
--- a/lldb/cmake/modules/AddLLDB.cmake
+++ b/lldb/cmake/modules/AddLLDB.cmake
@@ -105,7 +105,7 @@ function(add_lldb_library name)
   # this may result in the wrong install DESTINATION. The FRAMEWORK property
   # must be set earlier.
   if(PARAM_FRAMEWORK)
-    set_target_properties(liblldb PROPERTIES FRAMEWORK ON)
+    set_target_properties(${name} PROPERTIES FRAMEWORK ON)
   endif()
 
   if(PARAM_SHARED)