[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

[Michael Buch via Phabricator via lldb-commits]

Michael137 added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2480
+  // templates parameters, try again with the template parameters stripped since
+  // with simplified template names the DT_name may only contain the base name.
+  if (types.Empty()) {
----------------
Minor: might be easier for future readers to cross-reference


================
Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:9326-9328
+    auto i = template_basename.find('<');
+    if (i != std::string::npos)
+      template_basename.erase(i);
----------------
Minor

Wonder if it's worth commenting why the template_basename may or may not contain a `<`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134378/new/

https://reviews.llvm.org/D134378