[Lldb-commits] [PATCH] D135169: [LLDB] Fix printing a static bool struct member when using "image lookup -t"

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added inline comments.


================
Comment at: clang/include/clang/AST/ExprCXX.h:733
 
+  static CXXBoolLiteralExpr *Create(const ASTContext &C, bool Val, QualType Ty,
+                                    SourceLocation Loc) {
----------------
shafik wrote:
> I think this makes sense but if we are going to do this refactor then we should clean up all the locations we are currently doing `new (Context) CXXBoolLiteralExpr(....)` as well.
> 
> Maybe that should be the initial PR and then this change would be a follow-up.
Sounds good to me, I'll do that.


================
Comment at: lldb/test/API/lang/cpp/const_static_integral_member/TestConstStaticIntegralMember.py:36
+        # Test a bool member when printing the struct it is a member of.
+        # TODO: replace this with printing struct A, once doing so doesn't crash lldb.
+        self.expect("image lookup -t StaticBoolStruct",
----------------
And just to be clear, this is TODO is resolved in the patch stacked on this one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135169/new/

https://reviews.llvm.org/D135169