[Lldb-commits] [PATCH] D134656: [LLDB][NativePDB] Add class/union layout bit size.

Mon Oct 3 07:46:04 PDT 2022

labath added a comment.

In D134656#3819025 <https://reviews.llvm.org/D134656#3819025>, @zequanwu wrote:

>>> For members from parent classes, pdb only has information saying that its direct parents class are at some offsets for this class. For class without vtable, it's easy to calculate inherited member offsets by adding parent class offsets with their member offsets. For class with vtable, it's more complicated to calculate the offsets.
>>
>> Yes, so should we take the offsets from the debug info and provide them to clang (so that it does not have to recompute the offsets) ?
>
> Oh, it's already there <https://github.com/llvm/llvm-project/blob/main/lldb/source/Plugins/SymbolFile/NativePDB/UdtRecordCompleter.cpp#L259>. This patch just add the missing bit_size.

Ah, cool. Ok then.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134656/new/

https://reviews.llvm.org/D134656