[Lldb-commits] [PATCH] D135031: [lldb] [llgs] Move client-server communication into a separate thread (WIP)

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sun Oct 2 03:50:57 PDT 2022


mgorny created this revision.
mgorny added reviewers: krytarowski, emaste, labath, jingham.
Herald added a subscriber: arichardson.
Herald added a project: All.
mgorny requested review of this revision.

Perform all the communication between client and server in a dedicated
thread that's started after establishing the connection.  The thread
uses a MainLoop instance to read all incoming packets into a queue,
and handle asynchronous requests from the client via
the AddPendingCallback() API.

Using a dedicated thread will make it possible to continuously read
asynchronous notifications from running processes while permitting
the plugin to simultaneously handle synchronous requests in multiprocess
mode.

Sponsored by: The FreeBSD Foundation

TODO:

- implement complete error handling
- implement timeouts


https://reviews.llvm.org/D135031

Files:
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.h
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D135031.464547.patch
Type: text/x-patch
Size: 12317 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20221002/61528ace/attachment-0001.bin>


More information about the lldb-commits mailing list