[Lldb-commits] [PATCH] D134882: [lldb] Move breakpoint hit reset code to Target::CreateProcess

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Sep 30 10:07:54 PDT 2022


jingham added a comment.

The WillXXX have the virtue that they are at least self-documenting "Before you do XXX this will be called."  As it stands somebody working on Target could be forgiven for thinking Target::CreateProcess was just a convenience method, and redo it somewhere inline.  If we are going to require CreateProcess as the only way to do this, we should at least state that somewhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134882/new/

https://reviews.llvm.org/D134882



More information about the lldb-commits mailing list