[Lldb-commits] [PATCH] D134927: Make the sanitizer Notify callbacks asynchronous

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.

LGTM



================
Comment at: lldb/source/Plugins/InstrumentationRuntime/ASan/InstrumentationRuntimeASan.cpp:302-309
   bool internal = true;
   bool hardware = false;
   Breakpoint *breakpoint =
       process_sp->GetTarget()
           .CreateBreakpoint(symbol_address, internal, hardware)
           .get();
   breakpoint->SetCallback(InstrumentationRuntimeASan::NotifyBreakpointHit, this,
----------------
Might be nice spell this out explicitly, like we do for the `internal` and `hardware` arguments to `CreateBreakpoint`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134927/new/

https://reviews.llvm.org/D134927