[Lldb-commits] [PATCH] D134920: [lldb] Remove scoped timer from high firing and fast running ExtractUnitDIENoDwoIfNeeded
Dave Lee via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Sep 29 16:17:25 PDT 2022
kastiglione created this revision.
kastiglione added a reviewer: JDevlieghere.
Herald added a project: All.
kastiglione requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Profiles show that `DWARFUnit::ExtractUnitDIENoDwoIfNeeded` is both high firing (tens of thousands of calls) and fast running (15 µs mean).
Timers like this are noise and load for profiling systems, and can be removed.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D134920
Files:
lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
Index: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
===================================================================
--- lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
+++ lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
@@ -51,8 +51,6 @@
return; // Already parsed
ElapsedTime elapsed(m_dwarf.GetDebugInfoParseTimeRef());
- LLDB_SCOPED_TIMERF("%8.8x: DWARFUnit::ExtractUnitDIENoDwoIfNeeded()",
- GetOffset());
// Set the offset to that of the first DIE and calculate the start of the
// next compilation unit header.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D134920.464082.patch
Type: text/x-patch
Size: 571 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220929/cbfd27af/attachment.bin>
More information about the lldb-commits
mailing list