[Lldb-commits] [PATCH] D134877: [lldb] Fixes for swig-4.1.0 macro definition correction

Thu Sep 29 08:39:32 PDT 2022

serge-sans-paille added a comment.

In D134877#3823855 <https://reviews.llvm.org/D134877#3823855>, @labath wrote:

> Looking at https://bugzilla.redhat.com/show_bug.cgi?id=2128646, I'd say that the real bug is that we're defining this macro in two places. How about we leave these definitions as they are, and remove the one at `bindings/interfaces.swig:5` ?

In that case I would advocate for keeping the definition in the header, as it's commented (which means adding a definition for __STDC_CONSTANT_MACROS in the interface too).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134877/new/

https://reviews.llvm.org/D134877