[Lldb-commits] [PATCH] D134508: Track which modules have debug info variable errors.

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

In D134508#3818888 <https://reviews.llvm.org/D134508#3818888>, @JDevlieghere wrote:

> Instead of storing a bool, would it make sense to store the error instead and then have the statistics call `isFail` on it to determine whether there was an issue?

We would need to store a list of unique error strings if we want to go that route since we might stop N times in M compile units and currently the errors are on the compile unit boundary. We wouldn't want just one string and if we stopped 12 times in a the same function we don't want 12 copies of the same string in the stats. So if we could use a

  std::set<std::string> m_var_errors;

I'd be happy to go this route if anyone feels this would be useful. I just want to know when there are errors, but I also would love to have the exact errors to help us track down.

Please chime in everyone!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134508/new/

https://reviews.llvm.org/D134508