[Lldb-commits] [PATCH] D133858: [lldb] Reset breakpoint hit count before new runs

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

In D133858#3818755 <https://reviews.llvm.org/D133858#3818755>, @jingham wrote:

> If we use Target::CreateProcess to handle this task, how do we ensure that that will always get called any time we make a new process?

I'm not really sure how to answer that.

Clearly something like that can happen, but I think the overall risk is low. The most likely scenario for that happening would be if someone adds a new, fourth, method of initiating a process (in addition to launching, attaching and connecting), but I just don't know what would that be. But if one is doing that, I think it's at least as likely that he will forget to create the `DoWillInitiate` method and call the breakpoint reset function from there.

I think the only way to ensure that can't happen is to store the actual hit counts within the Process class itself, but I don't think anyone has an apetite to design something like that.

Anyone trying to create a function by bypassing a function called CreateProcess should think really hard before proceeding. And the more stuff we put into that function, the harder it will be for someone to bypass it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133858/new/

https://reviews.llvm.org/D133858