[Lldb-commits] [PATCH] D134751: [lldb] Fix running tests when LLVM target triple is different from host

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere requested changes to this revision.
JDevlieghere added a comment.
This revision now requires changes to proceed.

Supporting builds with different host and target triples makes sense. However, I have a few concerns about the current patch:

- I wouldn't cal it the "host triple". The API tests (`dotest.py`) support running the test suite for a different platform/architecture. Take a look at the Darwin builder and you'll see a bunch of support for that.
- How does this interact with the `-arch` flag? When the host and target triple differ, which part of the triple is different? In theory it can be any part, but maybe your use case could be covered by setting the `--arch` flag?
- This doesn't update `getTriple` in `builder.py` which is necessary for some of the decorators to work (in particular the ones that invoke the compiler to see if something is supported).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134751/new/

https://reviews.llvm.org/D134751