[Lldb-commits] [PATCH] D134636: [lldb][Windows] Always call SetExecutableModule on debugger connected

Tue Sep 27 10:48:35 PDT 2022

alvinhochun added a comment.

Okay, I'll rebase the change to remove the dependency on D134581 <https://reviews.llvm.org/D134581>.

================
Comment at: lldb/test/Shell/Target/dependent-modules-nodupe-windows.test:21-22
 # CHECK-NEXT: .main.exe
-# CHECK-NEXT: .shlib.dll
+# CHECK-NEXT: ntdll.dll
+# CHECK-NEXT: kernel32.dll
+# CHECK:      .shlib.dll
----------------
labath wrote:
> I'm not sure if hardcoding the order of system libraries (something which you have no control of) is such a good idea.
I think it's fine-ish. AFAIK ntdll.dll is pretty much guaranteed to be loaded by the loader ahead of other DLLs and kernel32.dll is depended on by almost everything else. It is definitely an implementation detail though so I can understand the concern.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134636/new/

https://reviews.llvm.org/D134636