[Lldb-commits] [lldb] 10a3563 - [lldb] Skip tests incompatible with older versions of Clang

[Felipe de Azevedo Piovezan via lldb-commits]

Author: Felipe de Azevedo Piovezan
Date: 2022-09-26T13:27:51-04:00
New Revision: 10a35632d55bb05004fe3d0c2d4432bb74897ee7

URL: https://github.com/llvm/llvm-project/commit/10a35632d55bb05004fe3d0c2d4432bb74897ee7
DIFF: https://github.com/llvm/llvm-project/commit/10a35632d55bb05004fe3d0c2d4432bb74897ee7.diff

LOG: [lldb] Skip tests incompatible with older versions of Clang

The coroutine tests require a standard library implementation of
coroutines, which was only made available some time _after_ Clang 13.
The first such Clang tested by the LLDB matrix bot is 15.0.1

The TestObjCExceptions test forces the use of the system's libcxx. For
the lldb matrix bot, the first Clang version compatible with the bot's
libraries is 13.0.

Differential Revision: https://reviews.llvm.org/D134645

Added: 
    

Modified: 
    lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/coroutine_handle/TestCoroutineHandle.py
    lldb/test/API/lang/objc/exceptions/TestObjCExceptions.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/coroutine_handle/TestCoroutineHandle.py b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/coroutine_handle/TestCoroutineHandle.py
index 8288fcff6aae4..224a550a5346d 100644
--- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/coroutine_handle/TestCoroutineHandle.py
+++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/coroutine_handle/TestCoroutineHandle.py
@@ -79,5 +79,6 @@ def test_libstdcpp(self):
         self.do_test(USE_LIBSTDCPP)
 
     @add_test_categories(["libc++"])
+    @skipIf(compiler="clang", compiler_version=['<', '15.0'])
     def test_libcpp(self):
         self.do_test(USE_LIBCPP)

diff  --git a/lldb/test/API/lang/objc/exceptions/TestObjCExceptions.py b/lldb/test/API/lang/objc/exceptions/TestObjCExceptions.py
index 663ab11ddfd56..23d94663c1d07 100644
--- a/lldb/test/API/lang/objc/exceptions/TestObjCExceptions.py
+++ b/lldb/test/API/lang/objc/exceptions/TestObjCExceptions.py
@@ -13,6 +13,7 @@
 
 class ObjCExceptionsTestCase(TestBase):
 
+    @skipIf(compiler="clang", compiler_version=['<', '13.0'])
     def test_objc_exceptions_at_throw(self):
         self.build()
 
@@ -123,6 +124,7 @@ def test_objc_exceptions_at_throw(self):
         for n in ["objc_exception_throw", "foo(int)", "main"]:
             self.assertIn(n, names, "%s is in the exception backtrace (%s)" % (n, names))
 
+    @skipIf(compiler="clang", compiler_version=['<', '13.0'])
     def test_objc_exceptions_at_abort(self):
         self.build()
 
@@ -179,6 +181,7 @@ def test_objc_exceptions_at_abort(self):
         for n in ["objc_exception_throw", "foo(int)", "rethrow(int)", "main"]:
             self.assertEqual(len([f for f in history_thread.frames if f.GetFunctionName() == n]), 1)
 
+    @skipIf(compiler="clang", compiler_version=['<', '13.0'])
     def test_cxx_exceptions_at_abort(self):
         self.build()