[Lldb-commits] [PATCH] D134509: [LLDB][NativePDB] Let native pdb use class layout in debug info.

Fri Sep 23 11:11:12 PDT 2022

zequanwu marked an inline comment as done.
zequanwu added a comment.

In D134509#3811203 <https://reviews.llvm.org/D134509#3811203>, @labath wrote:

> It's not clear to me how much of this patch is pure refactoring, and how much of it is adding new features. It would have been better to split that out into two patches.
>
> I see some layout handling code in `UdtRecordCompleter` constructor, but that's just two lines of code. Is that it, or should I look elsewhere?

That change in `UdtRecordCompleter` is fixing the class layout bit size. I'll put it in a separate patch.

Now this patch just does refactoring and hooks PdbAstBuilder to TypeSystem to use class layout in native pdb.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134509/new/

https://reviews.llvm.org/D134509