[Lldb-commits] [PATCH] D134536: [LLDB] Add an llvm::Optional version of GetRegisterInfo

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added a reviewer: clayborg.
DavidSpickett added a subscriber: clayborg.
DavidSpickett added a comment.

@clayborg As promised on https://reviews.llvm.org/D134041.

The strategy is:

- Make the original function concrete and have it call the optional version.
- Derived classes implement the optional version.
- One by one (or rather, manageable patch by manageable patch) switch the callers to the optional version.
- Remove the original function.

I've stacked the changes to do that onto this one. ARM is by far the largest, even if it is fairly mechanical changes.

You'll see some dodgy stuff like `&(*info)` because some APIs want a `RegisterInfo*`, but that's another rabbit hole I do want to look at but not here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134536/new/

https://reviews.llvm.org/D134536