[Lldb-commits] [PATCH] D134518: [lldb][COFF] Skip forwarder export symbols in symtab

Martin Storsjö via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Sep 23 03:46:36 PDT 2022


mstorsjo added a comment.

In D134518#3811153 <https://reviews.llvm.org/D134518#3811153>, @labath wrote:

> They may not be useful (at the moment), but if they're not actively causing harm (e.g. stopping some other feature from functioning, or if we're badly misrepresenting them in the symtab output), then I think we should keep them. You never know -- maybe someone will find a use for them.

Hm, maybe, but they're just plain symbols even without an associated address? @alvinhochun If we keep them, do we need to adjust the code below to handle the fact that they're addressless?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134518/new/

https://reviews.llvm.org/D134518



More information about the lldb-commits mailing list