[Lldb-commits] [PATCH] D134516: [lldb] Improve display of absolute symbol lookup

Fri Sep 23 02:59:14 PDT 2022

DavidSpickett accepted this revision.
DavidSpickett added a comment.
This revision is now accepted and ready to land.

LGTM

================
Comment at: lldb/source/Commands/CommandObjectTarget.cpp:1552
           strm.IndentMore();
+          strm.Indent("    Name: ");
+          strm.PutCString(symbol->GetDisplayName().GetStringRef());
----------------
alvinhochun wrote:
> DavidSpickett wrote:
> > Could you use the stream's indent here instead of `"     Foo:"`? You can pass a number of spaces to pad `void IndentMore(unsigned amount = 2);`.
> I was just following the pre-existing code below and also in `DumpAddress`. I do have some issues with the output of the lookup command when there are multiple results -- there is no separation between different results which makes the output a bit hard to parse (and is why I made a semi-related patch in D134111), perhaps we can try to improve it more in a separate change.
Fair enough, I'd like it to be all `stream.Indent` but the result is the same so that's fine.

It mostly helps if you come back later and add another level within this, but that doesn't seem likely here.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134516/new/

https://reviews.llvm.org/D134516